refactor: clean up jinja, vars, common variables, ansible-lint warnings#319
Merged
richm merged 1 commit intoredhat-cop:mainfrom Dec 22, 2025
Merged
refactor: clean up jinja, vars, common variables, ansible-lint warnings#319richm merged 1 commit intoredhat-cop:mainfrom
richm merged 1 commit intoredhat-cop:mainfrom
Conversation
richm
force-pushed
the
more-code-cleanup
branch
from
91d7966 to
58f6b1f
Compare
Collaborator
Author
|
[citest] |
Collaborator
Author
|
errors are fixed in #318 |
spetrosi
approved these changes
Dec 22, 2025
spetrosi
reviewed
Dec 22, 2025
Instead of suppressing ansible-lint issues in the warn list, fix the issues. Fix jinja warnings - use default variables for lists instead of jinja remove leapp-upgrade package before each test to ensure role will install it remove leapp_inhibitors from vars file - it is a set_fact get default remediations by reading files from remediation tasks directory move common variables from analysis and upgrade into common Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
force-pushed
the
more-code-cleanup
branch
from
58f6b1f to
16c548d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of suppressing ansible-lint issues in the warn list, fix the issues.
Fix jinja warnings - use default variables for lists instead of jinja
remove leapp-upgrade package before each test to ensure role will install it
remove leapp_inhibitors from vars file - it is a set_fact
get default remediations by reading files from remediation tasks directory
move common variables from analysis and upgrade into common
Signed-off-by: Rich Megginson rmeggins@redhat.com